Missing sharedassets0.assets file in language patch does not terminate install

Open Beginner friendly
#193 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
65/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
python
Domain
cli, tooling

Research direction

Look for the code that extracts the language patch archive and handles the sharedassets0.assets file. The installer likely has a function that checks for this file; modify it to raise an error or stop the installation if the file is missing. Check related issue #192 for context on warnings vs. errors. Test by simulating a language patch missing the sharedassets0.assets file.

Written by the indexing model from the issue text.

Description

Currently, if a matching sharedassets0.assets file is not found in the language patch, the installer will just hope for the best and use the default one.

It may be a better idea to stop the install with an error if this happens.

I think the way it works currently is that we extract the whole language patch archive directly, which automatically overwrites the sharedassets0.assets. But it may be better to leave the install as-is, without the language patch installed, if we know for sure it won't work.

Also see #192 if this is still to be treated as a warning, not an error

Dominant language
JavaScript
Stars
214
Forks
12
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from 07th-mod/python-patcher

All issues in 07th-mod/python-patcher

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.